Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Error in odh-model-controller logs on deletion of ModelMesh isvc #260

Closed
vaibhavjainwiz opened this issue Dec 12, 2023 · 2 comments
Closed
Assignees

Comments

@vaibhavjainwiz
Copy link
Member

Below error is occuring in odh-model-controller logs on deletion of ModelMesh isvc

2023-12-12T09:36:58Z ERROR controllers.InferenceService Unable to clean up resources {"InferenceService": "example-onnx-mnist", "namespace": "kserve-demo", "error": "failed to delete ServiceAccount: serviceaccounts \"modelmesh-serving-sa\" is forbidden: User \"system:serviceaccount:opendatahub:odh-model-controller\" cannot delete resource \"serviceaccounts\" in API group \"\" in the namespace \"kserve-demo\""}
github.com/opendatahub-io/odh-model-controller/controllers.(*OpenshiftInferenceServiceReconciler).Reconcile
/workspace/controllers/inferenceservice_controller.go:76

@vaibhavjainwiz
Copy link
Member Author

On analysis, I found that odh-model-controller-role ClusterRole which is attached the odh-model-controller pod doesn't have access to delete serviceaccounts.

@vaibhavjainwiz vaibhavjainwiz self-assigned this Dec 12, 2023
@vaibhavjainwiz
Copy link
Member Author

closing this issue in favour of opendatahub-io/odh-model-controller#133

@heyselbi heyselbi moved this from New/Backlog to Under Review in ODH Model Serving Planning Dec 12, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Done in ODH Model Serving Planning Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant