Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ClusterStorageContainer for ModelMesh deployments #262

Open
lampajr opened this issue Jan 11, 2024 · 3 comments
Open

Investigate ClusterStorageContainer for ModelMesh deployments #262

lampajr opened this issue Jan 11, 2024 · 3 comments
Assignees
Labels
chore Project management or other issues that are not a bug or feature request

Comments

@lampajr
Copy link
Contributor

lampajr commented Jan 11, 2024

Based on https://github.com/opendatahub-io/model-registry/issues/254 initial findings it seems the new ClusterStorageContainer feature is not supported in ModelMesh.

Explore the possibility to make a similar feature working on ModelMesh deployments as well, i.e., unlock the possibility to manage custom URI storage locations like model-registry://....

@lampajr lampajr added the chore Project management or other issues that are not a bug or feature request label Jan 11, 2024
@lampajr lampajr self-assigned this Jan 11, 2024
@rareddy
Copy link
Contributor

rareddy commented Jan 11, 2024

Is there a corresponding issue on the upstream model mesh? I would think there needs to be some service provider uri boot stapping that needs to be done in a core component.

@lampajr
Copy link
Contributor Author

lampajr commented Jan 11, 2024

Is there a corresponding issue on the upstream model mesh? I would think there needs to be some service provider uri boot stapping that needs to be done in a core component.

+1 it should require some architectural rethinking from modelmesh point of view to reuse a similar feature because the actual modelmesh implementation does not make use of initContainers to fetch/download the model.
I created an issue to get some more information and to keep track of it: kserve/modelmesh-serving#471 but no updates so far from modelmesh side

@lampajr
Copy link
Contributor Author

lampajr commented Jan 11, 2024

fwiw I am currently exploring if we can, at least, have some ad hoc changes on our side. i.e., in [opendatahub-io/modelmesh-serving] for instance somewhere here https://github.com/opendatahub-io/modelmesh-serving/blob/ec13e8d296aa6d67d89365ca26cab3acc85d3f3a/pkg/predictor_source/inferenceservice_registry.go#L164-L198 - still need to evaluate, just some initial ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project management or other issues that are not a bug or feature request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants