-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate ch-comments to en-comments #2927
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: koko2pp <[email protected]>
cicheck |
Signed-off-by: koko2pp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that it is best not to break the original code format. Otherwise you will struggle with ci endlessly.🤣
*/ | ||
struct IoPerfMetric { | ||
uint64_t readCount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment translation should not break the original code format.
* | group id | | ||
* | 32 | 32 | | ||
* | logic pool id | copyset id | | ||
*/ | ||
inline GroupNid ToGroupNid(const LogicPoolID &logicPoolId, | ||
const CopysetID ©setId) { | ||
inline GroupNid ToGroupNid(const LogicPoolID& logicPoolId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
repeated with #2754 and ensure it. |
What problem does this PR solve?
Issue Number: #2576
Problem Summary: translate Chinese annotations to English annotations
What is changed and how it works?
What's Changed: The Chinese comments in the code files have been converted into English comments.
How it Works: Write a GO script. For various programming languages, extract all comments from code files using different regular expressions, then determine whether the comments contain Chinese characters. If there are Chinese characters, use the Baidu Translate API to translate the Chinese comments into English comments, and then write them back to the file.
Side effects(Breaking backward compatibility? Performance regression?): None
Check List
[1] Relevant documentation/comments is changed or added
[1] I acknowledge that all my contributions will be made under the project's license