Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve/toos-v2]: add list-may-broken-vol #2356

Closed
Cyber-SiKu opened this issue Mar 30, 2023 · 3 comments
Closed

[curve/toos-v2]: add list-may-broken-vol #2356

Cyber-SiKu opened this issue Mar 30, 2023 · 3 comments
Assignees

Comments

@Cyber-SiKu
Copy link
Contributor

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

we'd like to support bs list may-broken-vol command in curve tool

  • The implementation of the old tool is here:
    int CopysetCheck::PrintMayBrokenVolumes() {
    std::vector<std::string> fileNames;
    int res = core_->ListMayBrokenVolumes(&fileNames);
    if (res != 0) {
    std::cout << "ListMayBrokenVolumes fail" << std::endl;
    return -1;
    }
    for (const auto& fileName : fileNames) {
    std::cout << fileName << std::endl;
    }
    std::cout << "total count: " << fileNames.size() << std::endl;
    return 0;
    }
  • The old command input and out put:
curve_ops_tool list-may-broken-vol

-------
output:
No majority-peers-offline copysets
total count: 0

Refer to tool develop guide to get start, and paste the result of the command in pr.

Build compilation environment:https://github.com/opencurve/curve/blob/master/docs/cn/build_and_run.md

Describe the solution you'd like (描述你期望的解决方法)

Add subcommand clinet to curve bs list.

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@Cyber-SiKu
Copy link
Contributor Author

Someone has done some work in this pr, you can refer to it.

@zhanghuidinah
Copy link
Member

@baytan0720
Copy link
Member

I want to try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants