-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add a github actions workflow for lint #1257
Conversation
9a08129
to
be9bc85
Compare
@kolyshkin PTAL 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit; lgtm otherwise
@kolyshkin PTAL 🙏 |
Looks like linting is working, and detected an issue; could you add a commit (as first commit) to correct that issue? diff --git a/schema/config-schema.json b/schema/config-schema.json
index cb74342..5124def 100644
--- a/schema/config-schema.json
+++ b/schema/config-schema.json
@@ -226,14 +226,14 @@
"properties": {
"initial": {
"type": "string",
- "pattern": "^[0-9, -]*$"
+ "pattern": "^[0-9, -]*$"
},
"final": {
"type": "string",
- "pattern": "^[0-9, -]*$"
+ "pattern": "^[0-9, -]*$"
}
}
- }
+ }
}
},
"linux": { |
Signed-off-by: utam0k <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In order to prevent like #1255
It works fine: https://github.com/utam0k/runtime-spec/actions/runs/9534058439/job/26278029545