Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add a github actions workflow for lint #1257

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jun 16, 2024

schema/defs.json Outdated Show resolved Hide resolved
@utam0k utam0k force-pushed the ci-lint branch 2 times, most recently from 9a08129 to be9bc85 Compare June 16, 2024 12:11
@utam0k utam0k requested a review from AkihiroSuda June 16, 2024 12:12
@AkihiroSuda AkihiroSuda added this to the v1.2.1 (tentative) milestone Jun 16, 2024
@utam0k
Copy link
Member Author

utam0k commented Oct 30, 2024

@kolyshkin PTAL 🙏

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit; lgtm otherwise

@utam0k
Copy link
Member Author

utam0k commented Dec 9, 2024

@kolyshkin PTAL 🙏

@thaJeztah
Copy link
Member

Looks like linting is working, and detected an issue; could you add a commit (as first commit) to correct that issue?

diff --git a/schema/config-schema.json b/schema/config-schema.json
index cb74342..5124def 100644
--- a/schema/config-schema.json
+++ b/schema/config-schema.json
@@ -226,14 +226,14 @@
                     "properties": {
                         "initial": {
                             "type": "string",
-			    "pattern": "^[0-9, -]*$"
+                            "pattern": "^[0-9, -]*$"
                         },
                         "final": {
                             "type": "string",
-			    "pattern": "^[0-9, -]*$"
+                            "pattern": "^[0-9, -]*$"
                         }
                     }
-		}
+                }
             }
         },
         "linux": {

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon tianon merged commit 09fcb39 into opencontainers:main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants