Post search results to an AnchorLink #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linas
added a commit
to linas/atomspace
that referenced
this pull request
Dec 16, 2022
Linking results to the AnchorNode idea now seems like a bad idea, in retrospect. The ideas in opencog#2911 seem superior. So trash the AnchorNode support in the query subsystem. FWIW, if this kind of thing was wanted, a better solution would be a new kind of Value, that dequeued from a QueueValue, and plopped the results onto an AnchorNode. ***This*** is the real reason for stripping away this code: its not generic enough. This reverts commit 46dea8e, reversing changes made to 5ec84bb.
linas
added a commit
that referenced
this pull request
Dec 16, 2022
Linking results to the AnchorNode idea now seems like a bad idea, in retrospect. The ideas in #2911 seem superior. So trash the AnchorNode support in the query subsystem. FWIW, if this kind of thing was wanted, a better solution would be a new kind of Value, that dequeued from a QueueValue, and plopped the results onto an AnchorNode. ***This*** is the real reason for stripping away this code: its not generic enough. Merge branch 'revert-anchor'
|
This pull req was reverted in eee7a61 Basically, it just seemed like a bad idea, in the end. FWIW, if this kind of thing was wanted, a better solution would |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial, initial-draft solution to issue #1502 - it allows results
to be posted to an AnchorLink, instead of returning them in a SetLink.
The changes to enable this are small, and the example is easy.