Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin huggingface-hub to version 0.21.4 #69

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

agijsberts
Copy link
Contributor

Pull Request

Description

DGMR and NowcastingModelHubMixin in their present form are incompatible with huggingface-hub>=0.22, causing a KeyError: 'config' when trying to load the model with model = DGMR.from_pretrained("openclimatefix/dgmr"). This PR pins huggingface-hub to the latest working version for the moment, until a full solution can be developed.

Fixes #68

How Has This Been Tested?

Checked that the package installs and model loads as expected.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield reopened this Jun 11, 2024
@peterdudfield peterdudfield merged commit c191c80 into openclimatefix:main Jun 11, 2024
1 check failed
@peterdudfield
Copy link
Contributor

@all-contributors please add @agijsberts for code

Copy link
Contributor

@peterdudfield

I've put up a pull request to add @agijsberts! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading model using DGMR.from_pretrained("openclimatefix/dgmr") fails
2 participants