Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra ReLU in L Block #49

Open
najeeb-kazmi opened this issue Mar 10, 2023 · 3 comments
Open

Extra ReLU in L Block #49

najeeb-kazmi opened this issue Mar 10, 2023 · 3 comments

Comments

@najeeb-kazmi
Copy link

najeeb-kazmi commented Mar 10, 2023

x2 = self.relu(x)

I believe this first ReLU should not be present in the L Block, going by the diagram in the paper (Extended Data Figure 1, page 18).

@peterdudfield
Copy link
Contributor

Thanks @najeeb-kazmi for the question. I'll let @jacobbieker get back to you on this

@peterdudfield
Copy link
Contributor

@all-contributors please add @najeeb-kazmi for question

@allcontributors
Copy link
Contributor

@peterdudfield

I've put up a pull request to add @najeeb-kazmi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants