Move forecast csv test to test folder #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,55 @@ | |||
| import os | |||
There was a problem hiding this comment.
thanks this is great
|
This looks great, just remove a few of those extra files and then we can get it merged in. Thank you |
|
Done, thank you for calling out the extra files! |
|
Thank you @EmilyIsCoding |
|
I've put up a pull request to add @EmilyIsCoding! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Moves TestGenerateForecast to the test folder. Also changes it into a pytest with monkeypatch mock modules instead of unittest.
Fixes #207
How Has This Been Tested?
Ran
test_forecast.py,test_forecast_no_ts.pybefore and after changes as well astest_generate_forecast.py.Checklist: