add smooth blocks options #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sukh-P
reviewed
Nov 26, 2024
| @@ -189,6 +192,15 @@ def predict(self, site_id: str, timestamp: dt.datetime): | |||
| values_df["forecast_power_kw"].rolling(4, min_periods=1).mean().astype(int) | |||
| ) | |||
|
|
|||
| if self.smooth_blocks: | |||
There was a problem hiding this comment.
I just noticed there is some smoothing that happens just above this using 1 hour windows, does this mean this is this smoothing is applied on top of that one?
Feels like it would be useful have a unit test with non random forecast values to make sure this is working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add option for smoothing foreast in confi
How Has This Been Tested?
CI tests
Checklist: