Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop the _adapt_batch() from changing the batch in-place #210

Open
dfulu opened this issue Jun 5, 2024 · 0 comments
Open

Stop the _adapt_batch() from changing the batch in-place #210

dfulu opened this issue Jun 5, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dfulu
Copy link
Member

dfulu commented Jun 5, 2024 •
edited
Loading

The _adapt_batch() method changes the batch in-place. This is bad practice and led to a hard to find bug in pvnet_app. Instead it should return a new batch without changing the old one
@dfulu dfulu added bug Something isn't working good first issue Good for newcomers labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfulu