Training fixes #21
Merged
Training fixes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sukh-P
reviewed
Jun 20, 2024
| @@ -164,7 +163,7 @@ def _get_premade_batches_datapipe(self, subdir, shuffle=False, add_filename=Fals | |||
| file_pipeline = FileLister(f"{self.batch_dir}/{subdir}", masks="*.pt", recursive=False) | |||
|
|
|||
| if shuffle: | |||
| file_pipeline = file_pipeline.shuffle(buffer_size=1000) | |||
| file_pipeline = file_pipeline.shuffle(buffer_size=10_000) | |||
There was a problem hiding this comment.
Out of interest, what's the reason for the buffer size change here?
There was a problem hiding this comment.
No particular reason. Just that at this stage all we'll being doing is loading up to 1000 or 10,000 file names before shuffling them. I thought that since the filenames don't take up any amount of space why not use more and have a more complete shuffle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
relative_scale_pvnet_outputsoption, out input values to the network were of order 1E-4Note that this will break the compatibility with already trained summation models