Fixes #1512, don't save edits with no clips #1517
Open
+43
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts ☹ |
github-actions
bot
added
the
status:conflicts
|
This pull request is deployed at test.editor.opencast.org/1517/2024-12-11_11-36-08/ . |
JamesUoM
force-pushed
the
f/catch-video-deletion
branch
from
ab919e8 to
f0c2479
Compare
github-actions
bot
removed
the
status:conflicts
|
This pull request is deployed at test.editor.opencast.org/1517/2024-12-11_11-41-22/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before allowing the edits to be saved/processed, check that there isn't a single segment that deletes the whole video. Otherwise Opencast will create a SMIL file with not clips and the editor WOH will fail.