Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new filters not being loaded #914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Sep 13, 2024

Fixes #693.

When a new table filter was added to Opencast, it would not show up in the filters dropdown unless the page cache was cleared. This should fix that.

I legit do not understand why the code was the way it was before this commit. If a reviewer could enlighten me why the previous code makes sense that would be great, but personally I see no harm in fetching the respective table filters everytime we load a new table.

When a new table filter was added to Opencast,
it would not show up in the filters dropdown
unless the page cache was cleared. This should
fix that.

I legit do not understand why the code was the
way it was before this commit. If a reviewer
could enlighten me why the previous code
makes sense that would be great, but personally
I see no harm in fetching the respective table
filters everytime we load a new table.
@Arnei Arnei added the type:bug Something isn't working label Sep 13, 2024
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/914/2024-09-13_07-58-38/ .
It might take a few minutes for it to become available.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-914

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-914

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@lkiesow
Copy link
Member

lkiesow commented Nov 18, 2024

Can you give me a short description on how to best test this?

@Arnei
Copy link
Member Author

Arnei commented Nov 19, 2024

Right. At the time I used this PR to test this. It is now merged, so you would have to recreate it.

There are probably easier ways to test this, for example by modifying the result of the request in tableFilters/fetchFilters in tableFilterSlice.ts. I can provide more detailled code changes if you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data seems to be loaded from cache instead of loading from locally running Opencast
2 participants