Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MUI error when selecting a date as for StartDate filter #652

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ferishili
Copy link
Contributor

This PR fixes #636,

Upon selecting the StartDate filter and adding selecting a date, an error occurs in MUI level, which can be seen in the devtool console!

It is solved simply by making the endDate and startDate value so called "uncontrolled?" by making it optional as to force passing null!

@ferishili ferishili added type:bug Something isn't working bugbash labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/652/2024-06-05_14-30-20/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-652

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-652

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@lkiesow
Copy link
Member

lkiesow commented Jun 5, 2024

Probably makes sense to merge #654 first

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd fix, but can't argue with results!

@Arnei Arnei merged commit a957f74 into opencast:main Jun 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seleting a value for Datepicker in the filters throws error
3 participants