Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of fa buttons in actions column to have a better contrast ratio #651

Closed
wants to merge 1 commit into from

Conversation

rlucke
Copy link
Contributor

@rlucke rlucke commented Jun 5, 2024

Change color of fa buttons in actions column to have a better contrast ratio.

Fixes #637

@rlucke rlucke added the type:accessibility This would help impaired users label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Hi @rlucke
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/651/2024-06-05_14-05-05/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-651

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-651

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg ziegenberg changed the title fix #641 Change color of fa buttons in actions column to have a better contrast ratio Jun 5, 2024
@ziegenberg
Copy link
Member

ziegenberg commented Jun 5, 2024

Note: I changed the title for a better release note entry, as they are auto-generated.

@ziegenberg ziegenberg linked an issue Jun 5, 2024 that may be closed by this pull request
@ziegenberg
Copy link
Member

@rlucke Are you sure this is a fix for #641 and not maybe #637? Can you verify please?

@rlucke
Copy link
Contributor Author

rlucke commented Jun 6, 2024

You are absoluty right. Sorry for the mixup.

@rlucke rlucke closed this Jun 6, 2024
@rlucke rlucke deleted the issue-641 branch June 6, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:accessibility This would help impaired users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled buttons need more contrast Action icon contrast too low
2 participants