-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module declarations for svg and png ressources #458
Conversation
@Arnei, would you consider this a valid approach? |
Absolutely no expert on this, but if our goal is to get rid of Apart from getting typescript to shut up, this does not add anything of value I believe. We're basically declaring pngs as And you can probably shorten the module declarations down to just |
While switching to Vite, I had to remove the |
This pull request has conflicts ☹ |
Signed-off-by: Daniel Ziegenberg <[email protected]>
2d817b7
to
f7cfed7
Compare
This pull request is deployed at test.admin-interface.opencast.org/458/2024-06-04_10-21-30/ . |
I rebased and fixed the merge conflicts. @Arnei I also shortened the module declarations as suggested. |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
Actually, do we still need this? Or did this become unnecessary with the introduction of vite and stuff? |
@Arnei We still have messages like |
svgs should be handled by svgr |
So, then let's close this. |
Removes a bunch of
ts-expect-error
: