Correctly import zh-CN and zh-TW and remove language flags #457

ziegenberg · 2024-05-24T12:34:10Z

This fixes the garbled use of zh-CN and zh-TW. We used the flag from the one, the description of the other and only used one, so somehow got it mixed up.

The strings 简体中文 and 繁體中文 were approved by a native speaker. We shouldn't be stepping on anybody's toes too badly ...

Apart from that we also enable importing .json files for the translations.

EDIT:
Also removing the language flags now

ziegenberg · 2024-05-24T13:41:05Z

@JulianKniephoff would you approve the changes in b817e4c?

github-actions · 2024-05-24T21:21:43Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

JulianKniephoff

The code changes I gladly approve. ✅ They work and seem reasonable.

Regarding the language stuff I have some thoughts, but obviously I'm not a native, so take this with a grain of salt. I did some research right now, but of course I'm not immersed in these cultures, and know very little about conventions and idiomatic use of these languages/terms. However, while I don't want to question any one person in particular, I do want to put out there that being a native does not necessarily qualify someone to answer these questions. Natives can be "wrong" about their languages, especially in a situation that's politically loaded like this one. Because remember, too, that we are dealing with two languages here, but see also below. Anyway:

First of all, by now we should all know that flags aren't langauges. Of course whether or not we want to keep the flags is a bigger discussion outside the scope of this PR. I just wanted to mention it for completeness.

What we should discuss here is what our translations actually represent, especially when talking about variants like this. Officially zh_CN is Chinese as spoken/written in the PRC, and zh_TW is Chinese as used in Taiwan. This is also what the flags suggest. I don't know and can't really verify whether that's what's in the translation files, but as far as I'm concerned that is what we are intending to provide here: A localization that's appropriate for mainland China and another one that's appropriate for Taiwan. And people who don't fall directly into these categories probably know/have a preference about which one of those they should pick. (Same way as we don't have a Canadian English translation, but @gregorydlogan still has an opinion about which one he wants. ;D)

And it is true (generally, probably simplifying a lot here) that that maps to simplified vs. traditional Chinese writing, but that's only part of it. However, if I understand correctly, 简体中文 and 繁體中文 specify exactly that, simplified and traditional Chinese writing. So are our two Chinese translations just the same texts but written in different writing systems? I don't think so. And even if, mapping that to flags would definitely be wrong then, and also I think it's kind of weird to have that while other translations have a rather clear connection to some territory. Also, the proper codes in that case would be zh_Hans and zh_Hant, but I'm not sure our setup would support that.

Anyway, these specific terms might be weird for another reason:

The government of Taiwan officially refers to traditional Chinese characters as 正體字; 正体字; zhèngtǐzì; 'orthodox characters'.[9] This term is also used outside Taiwan to distinguish standard characters, including both simplified, and traditional, from other variants and idiomatic characters.[10] Users of traditional characters elsewhere, as well as those using simplified characters, call traditional characters 繁體字
—Wikipedia

So I think it's weird to use 繁體中文 as the self-description of the zh_TW locale. IIUC it should be 正體中文, but what I'm really getting at is that we maybe should rather use the names these territories use for their own language, instead of just their writing system. Which, AFAIK, would be either 中文 for both, or 汉语 and 漢語 for PRC and Taiwan respectively.

TL;DR I propose changing this:

to either this (note again the similarity to English):

or this:

ziegenberg · 2024-05-28T14:13:34Z

How about getting rid of the flags at all? And switch from "English/English" to "US-English/GB-English"?

ziegenberg · 2024-05-28T14:23:52Z

I talked with my colleague (who is a native speaker) again. She said that "简体中文" / "繁體中文" is the most common form she comes across when switching languages in games and other applications.

Using 中文 for both provides the least value and the best would be to get rid of the flags all along. We could also argue why we have a German flag for the german language when there also could be a Swiss or an Australian flag used in that case...

ziegenberg · 2024-05-28T14:25:18Z

That's what Google offers when switching languages:

For traditional Chinese, they also offer a country selection:

geichelberger · 2024-05-28T22:13:35Z

Using 中文 for both provides the least value and the best would be to get rid of the flags all along. We could also argue why we have a German flag for the german language when there also could be a Swiss or an Australian flag used in that case...

🚫🦘

ziegenberg · 2024-05-29T08:25:04Z

Using 中文 for both provides the least value and the best would be to get rid of the flags all along. We could also argue why we have a German flag for the german language when there also could be a Swiss or an Australian flag used in that case...

🚫🦘

Autocorrection 🤨🙄🤬

JulianKniephoff · 2024-05-30T08:13:21Z

I'm definitely in favor of removing the flags. Regarding the wording I voiced my concerns, but I don't want to block anything with them. If Google uses these terms as well, that can of course still be wrong, but so can I, and I unfortunately don't have the resources right now to get deeper into it. 🤷‍♀️

One thing I would be interested in is what language codes Google maps these strings to. 🤔

ziegenberg · 2024-05-30T14:10:27Z

Google uses:

simplified Chinese

zn-CN with 简体中文

traditional Chinese
This has a country selection and then either

zh-TW with 繁體中文
zh-HK with 繁體中文
zh-MO with 繁體中文

Crowdin provides "Chinese Simplified" (zn-CN) and "Chinese Traditional" (zn-TW), and then "Chinese Traditional" with the addition of Hongkong, Macau and Singapore.

github-actions · 2024-05-30T14:33:41Z

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-457

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-457

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

ziegenberg · 2024-05-30T14:36:39Z

@JulianKniephoff I rebased and removed the flags. Can you have a look once more?

github-actions · 2024-05-31T10:09:52Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2024-05-31T11:19:46Z

This pull request is deployed at test.admin-interface.opencast.org/457/2024-05-31_11-19-08/ .
It might take a few minutes for it to become available.

JulianKniephoff

Some nitpicks in the code.

For everyone's convenience, this is what it looks like now:

tsconfig.json

src/components/Header.tsx

JulianKniephoff · 2024-06-03T15:50:35Z

src/components/Header.tsx

-							onClick={() => setMenuLang(!displayMenuLang)}
-						>
-							<img src={currentLanguage?.flag} alt={currentLanguage?.code} />
+						<div className="lang" title={t("LANGUAGE")} onClick={() => setMenuLang(!displayMenuLang)}>


I would get rid of the title attribute in this case, this element is now self-describing. Also, can we get rid of the LANGUAGE translation key then?

OR we use that as the text for the selector, not the selected language.

Or we use it as alt for a generic language selector icon, like the typical globe or the "A文" thing you see sometimes. 🤔

I would got for the third option.

@JulianKniephoff which of the two icons do you prefer?

FaGlobe from "react-icons/fa"

FaLanguage from "react-icons/fa"

I will leave the title attribute in here, as it creates a nice pop-over

I think I prefer the globe in this case 🤔

github-actions · 2024-06-04T08:23:24Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2024-06-04T09:15:14Z

This pull request is deployed at test.admin-interface.opencast.org/457/2024-06-04_09-14-33/ .
It might take a few minutes for it to become available.

github-actions · 2024-06-04T09:56:41Z

This pull request is deployed at test.admin-interface.opencast.org/457/2024-06-04_09-56-02/ .
It might take a few minutes for it to become available.

lkiesow · 2024-06-04T14:25:31Z

The selector looks fine, except the icon which is different from all other tools we have (studio, editor, tobira) and three people told me (and I agree) that they didn't identify this as a language selector. It looks like something related to internet or network or something like that.

Can we just use what we use in the other tools?

Except for that, I'm fine with the new dialog.

ziegenberg · 2024-06-04T15:11:29Z

The selector looks fine, except the icon which is different from all other tools we have (studio, editor, tobira) and three people told me (and I agree) that they didn't identify this as a language selector. It looks like something related to internet or network or something like that.

Can we just use what we use in the other tools?

@lkiesow, would you be okay with the second version, like here: #457 (comment)? I would stay within the same iconography, and that's currently FontAwesome5. We can change this at a later stage.

@JulianKniephoff prefers the globe.

github-actions · 2024-06-07T11:05:09Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

lkiesow · 2024-06-07T11:15:43Z

@lkiesow, would you be okay with the second version, like here: #457 (comment)? I would stay within the same iconography, and that's currently FontAwesome5. We can change this at a later stage.

Sorry for the late reply. Lots of other patches drawing attention ;-)
That's definitely better. But judging by your poll in Matrix, you might have already decided to go with another icon.

This fixes the garbled use of zh-CN and zh-TW. We used the flag from the one, the description of the other and only used one, so somehow got it mixed up. The strings 简体中文 and 繁體中文 were approved by a native speaker. We shouldn't be stepping on anybody's toes too badly ... Signed-off-by: Daniel Ziegenberg <[email protected]>

Removes a bunch of ts-expect-error TS(2307) Signed-off-by: Daniel Ziegenberg <[email protected]>

Signed-off-by: Daniel Ziegenberg <[email protected]>

github-actions · 2024-06-11T15:48:24Z

This pull request is deployed at test.admin-interface.opencast.org/457/2024-06-11_15-53-53/ .
It might take a few minutes for it to become available.

Signed-off-by: Daniel Ziegenberg <[email protected]>

ziegenberg added the type:bug Something isn't working label May 24, 2024

github-actions bot added the status:conflicts label May 24, 2024

ziegenberg force-pushed the fix-i18n-languages branch from b817e4c to 281d73a Compare May 25, 2024 16:11

github-actions bot removed the status:conflicts label May 25, 2024

JulianKniephoff self-assigned this May 27, 2024

JulianKniephoff self-requested a review May 27, 2024 12:53

JulianKniephoff reviewed May 27, 2024

View reviewed changes

ziegenberg added the discuss in dev meeting Pull requests that should be discussed in the dev meeting on tuesdays label May 28, 2024

ziegenberg force-pushed the fix-i18n-languages branch from 281d73a to d8eb7b3 Compare May 30, 2024 14:32

ziegenberg removed the discuss in dev meeting Pull requests that should be discussed in the dev meeting on tuesdays label May 30, 2024

ziegenberg changed the title ~~Correctly import zh-CN and zh-TW~~ Correctly import zh-CN and zh-TW and remove language flags May 30, 2024

github-actions bot added the status:conflicts label May 31, 2024

ziegenberg force-pushed the fix-i18n-languages branch from d8eb7b3 to 7f8be75 Compare May 31, 2024 11:18

github-actions bot removed the status:conflicts label May 31, 2024

JulianKniephoff self-requested a review June 3, 2024 09:59

JulianKniephoff requested changes Jun 3, 2024

View reviewed changes

github-actions bot added the status:conflicts label Jun 4, 2024

ziegenberg force-pushed the fix-i18n-languages branch from 7f8be75 to 4a6ecb8 Compare June 4, 2024 09:14

github-actions bot removed the status:conflicts label Jun 4, 2024

ziegenberg force-pushed the fix-i18n-languages branch from 4a6ecb8 to 3161d44 Compare June 4, 2024 09:55

ziegenberg requested a review from JulianKniephoff June 4, 2024 09:56

github-actions bot added the status:conflicts label Jun 7, 2024

ziegenberg added 3 commits June 11, 2024 17:28

Enable importing .json files

f0077ba

Removes a bunch of ts-expect-error TS(2307) Signed-off-by: Daniel Ziegenberg <[email protected]>

remove language flags alltogether

e4d142f

Signed-off-by: Daniel Ziegenberg <[email protected]>

ziegenberg force-pushed the fix-i18n-languages branch from 3161d44 to 4a66fe7 Compare June 11, 2024 15:47

github-actions bot removed the status:conflicts label Jun 11, 2024

use a translate glyph instead of the current language

91e75d4

Signed-off-by: Daniel Ziegenberg <[email protected]>

ziegenberg force-pushed the fix-i18n-languages branch from 4a66fe7 to 91e75d4 Compare June 11, 2024 15:53

lkiesow self-assigned this Jun 11, 2024

lkiesow approved these changes Jun 11, 2024

View reviewed changes

lkiesow merged commit 8812a3a into opencast:main Jun 11, 2024
5 checks passed

ziegenberg deleted the fix-i18n-languages branch June 12, 2024 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correctly import zh-CN and zh-TW and remove language flags #457

Correctly import zh-CN and zh-TW and remove language flags #457

ziegenberg commented May 24, 2024 •

edited

Loading

ziegenberg commented May 24, 2024

github-actions bot commented May 24, 2024

JulianKniephoff left a comment •

edited

Loading

ziegenberg commented May 28, 2024

ziegenberg commented May 28, 2024

ziegenberg commented May 28, 2024

geichelberger commented May 28, 2024

ziegenberg commented May 29, 2024

JulianKniephoff commented May 30, 2024

ziegenberg commented May 30, 2024

github-actions bot commented May 30, 2024 •

edited

Loading

ziegenberg commented May 30, 2024

github-actions bot commented May 31, 2024

github-actions bot commented May 31, 2024

JulianKniephoff left a comment

JulianKniephoff Jun 3, 2024

ziegenberg Jun 4, 2024

ziegenberg Jun 4, 2024

ziegenberg Jun 4, 2024

JulianKniephoff Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

lkiesow commented Jun 4, 2024

ziegenberg commented Jun 4, 2024

github-actions bot commented Jun 7, 2024

lkiesow commented Jun 7, 2024

github-actions bot commented Jun 11, 2024 •

edited

Loading

Correctly import zh-CN and zh-TW and remove language flags #457

Correctly import zh-CN and zh-TW and remove language flags #457

Conversation

ziegenberg commented May 24, 2024 • edited Loading

ziegenberg commented May 24, 2024

github-actions bot commented May 24, 2024

JulianKniephoff left a comment • edited Loading

Choose a reason for hiding this comment

ziegenberg commented May 28, 2024

ziegenberg commented May 28, 2024

ziegenberg commented May 28, 2024

geichelberger commented May 28, 2024

ziegenberg commented May 29, 2024

JulianKniephoff commented May 30, 2024

ziegenberg commented May 30, 2024

github-actions bot commented May 30, 2024 • edited Loading

ziegenberg commented May 30, 2024

github-actions bot commented May 31, 2024

github-actions bot commented May 31, 2024

JulianKniephoff left a comment

Choose a reason for hiding this comment

JulianKniephoff Jun 3, 2024

Choose a reason for hiding this comment

ziegenberg Jun 4, 2024

Choose a reason for hiding this comment

ziegenberg Jun 4, 2024

Choose a reason for hiding this comment

ziegenberg Jun 4, 2024

Choose a reason for hiding this comment

JulianKniephoff Jun 4, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

lkiesow commented Jun 4, 2024

ziegenberg commented Jun 4, 2024

github-actions bot commented Jun 7, 2024

lkiesow commented Jun 7, 2024

github-actions bot commented Jun 11, 2024 • edited Loading

ziegenberg commented May 24, 2024 •

edited

Loading

JulianKniephoff left a comment •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading