Fix build warnings #430
Merged
Fix build warnings #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKniephoff
added
the
type:code-enhancement
This comment was marked as resolved.
This comment was marked as resolved.
JulianKniephoff
force-pushed
the
fix-build-warnings
branch
from
da2ca5d to
5554c67
Compare
Arnei
requested changes
May 24, 2024
There was a problem hiding this comment.
Changes look reasonable to me, and there are no more remaining warnings. Good!
One thing I would like to see is some form of reminder for disabled warnings, where "fixing them is too complicated for now", so we don't lose sight of them. Maybe as a Github issue?
This comment was marked as resolved.
This comment was marked as resolved.
JulianKniephoff
force-pushed
the
fix-build-warnings
branch
from
5554c67 to
e508a62
Compare
|
I was thinking of more specific issues, especially since |
Arnei
approved these changes
May 28, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Specifically: > One of your dependencies, babel-preset-react-app, is importing the > "@babel/plugin-proposal-private-property-in-object" package without > declaring it in its dependencies. This is currently working because > "@babel/plugin-proposal-private-property-in-object" is already in your > node_modules folder for unrelated reasons, but it may break at any time. > babel-preset-react-app is part of the create-react-app project, which > is not maintianed anymore. It is thus unlikely that this bug will > ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to > your devDependencies to work around this error. This will make this message > go away.
Either by fixing them or by adding them to the long list of locally disabled ones, when fixing them is too complicated for now. May contain traces of formatting related nitpicks.
This also touches our vendored copy of fontawesome. See opencast#429.
JulianKniephoff
force-pushed
the
fix-build-warnings
branch
from
e508a62 to
2fce570
Compare
|
Use Local test with mock data Proxy data from develop.opencast.org It may take a few seconds for the interface to spin up. |
ziegenberg
approved these changes
May 30, 2024
lkiesow
added a commit
to lkiesow/opencast-admin-interface
that referenced
this pull request
May 31, 2024
As all the warnings on the build are now fixed (thx to opencast#430), we no longer need to set `CI=false` to actively suppress warnings to be picked up by our CI tests. This should help with us not introducing new warnings.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #350.
See individual commit messages for more details.