Better naming for Crowdin workflows #407
Conversation
There was a problem hiding this comment.
The line
crowdin download --config .crowdin.yaml -b admin-ui-picard
probably also needs changing, and the branch name updated to main.
That's what the last GHA error suggest: https://github.com/opencast/opencast-admin-interface/actions/runs/9153874134/job/25163529960
|
This pull request has conflicts ☹ |
Let all GitHub Actions workflow definitions for Crowdin… - have a filename starting with `crowdin-…` - Have a name starting with `Crowdin » `
|
Fixed conflicts and branch name |
| - name: update language list | ||
| working-directory: /src/i18n/org/opencastproject/adminui/languages/ | ||
| run: | | ||
| echo -n '[ "' > locales.json | ||
| echo -n ??-??.json | sed 's/ */", "/g' >> locales.json | ||
| echo '" ]' >> locales.json |
There was a problem hiding this comment.
Do we need this step? Isn't the list of languages configured here src/i18n/languages.ts?
| - name: download translations | ||
| env: | ||
| CROWDIN_TOKEN: ${{ secrets.CROWDIN_TOKEN }} | ||
| run: | | ||
| crowdin download --config .crowdin.yaml -b admin-ui-picard | ||
| crowdin download --config .crowdin.yaml -b main | ||
|
|
||
| - name: add new translations | ||
| run: | | ||
| git add /src/i18n/org/opencastproject/adminui/languages/ |
There was a problem hiding this comment.
Should we have those absolute file path here?
There was a problem hiding this comment.
The upstream project uses git commit -a here. Unsure which is less safe :D
There was a problem hiding this comment.
I'm just not sure if an absolute file path would work or if this should be relative to the current working directory...
There was a problem hiding this comment.
@lkiesow, could you quickly look at this? Then, we could merge it right after.
|
Looking good now! |
ziegenberg
added
type:infrastructure
Let all GitHub Actions workflow definitions for Crowdin…
crowdin-…Crowdin »