Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToGymEnv.reset does not respect Gym.Env.reset signature #8

Open
epignatelli opened this issue Jan 11, 2023 · 0 comments · May be fixed by #9
Open

ToGymEnv.reset does not respect Gym.Env.reset signature #8

epignatelli opened this issue Jan 11, 2023 · 0 comments · May be fixed by #9

Comments

@epignatelli
Copy link

epignatelli commented Jan 11, 2023 •
edited
Loading

- Issue

The signature in both gym.Env.reset and gymnasium.Env.reset include two optional parameters: seed and options.

Instead ToGymEnv.reset does not accept any parameter.

For example, env.reset(seed=0) will fail with a procgen environment.

- Reproduce

import gym

env = gym.make("procgen:procgen-coinrun-v0")
env.reset(seed=0)

- Proposed fix

ToGymEnv.reset should respect the Gym.Env.reset signature, even if parameters are ignored.

The proposal is in #9
@epignatelli epignatelli linked a pull request Jan 11, 2023 that will close this issue
Open
epignatelli added a commit to epignatelli/helx that referenced this issue Jan 11, 2023
@epignatelli
workaround openai/gym3#8
4698066
epignatelli added a commit to epignatelli/helx that referenced this issue Jan 12, 2023
@epignatelli
workaround openai/gym3#8
04f9e1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ToGymEnv.reset to respect Gym.Env.reset signature epignatelli/gym3
1 participant
@epignatelli