Image classification yolov5 model #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work!, could you merge your PR’s I see to many PRs and it misses the point of one PR for one task
This would help in getting the bigger picture of what changes you are making The above is applicable for following PRs |
This was referenced Apr 9, 2023
|
Hello Param,
I would do the changes and let you know.
Best regards,
Deepthi M
…On Sun, 9 Apr 2023 at 11:49 AM, Param Mirani ***@***.***> wrote:
Great work!, could you merge your PR’s I see to many PRs and it misses the
point of one PR for one task
I think you can merge PRs into the following 3
1. Data Augmentation
1. Add in the description of all the changes you are making Eg:
Rotation, blur, etc etc
2. Image classification
3. Object detection
1. Using YOLOv5s & CNN
This would help in getting the bigger picture of what changes you are
making
The above is applicable for following PRs
#253 <#253>-#301
<#301> (~50PRs in total)
—
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS3DRJOZSVRJEQ5GIBMYSYLXAJIGFANCNFSM6AAAAAAWL3MFAI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Following are the changes done as suggested by @param Mirani
<https://mifos.slack.com/team/U04UG3A359N>. Kindly check and do let me know
for further changes and give feedback please.
#308
#306
#304
On Sun, 9 Apr 2023 at 16:02, Deepthi ***@***.***>
wrote:
… Hello Param,
I would do the changes and let you know.
Best regards,
Deepthi M
On Sun, 9 Apr 2023 at 11:49 AM, Param Mirani ***@***.***>
wrote:
> Great work!, could you merge your PR’s I see to many PRs and it misses
> the point of one PR for one task
> I think you can merge PRs into the following 3
>
> 1. Data Augmentation
> 1. Add in the description of all the changes you are making Eg:
> Rotation, blur, etc etc
> 2. Image classification
> 3. Object detection
> 1. Using YOLOv5s & CNN
>
> This would help in getting the bigger picture of what changes you are
> making
>
> The above is applicable for following PRs
>
> #253 <#253>-#301
> <#301> (~50PRs in total)
>
> —
> Reply to this email directly, view it on GitHub
> <#301 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AS3DRJOZSVRJEQ5GIBMYSYLXAJIGFANCNFSM6AAAAAAWL3MFAI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
commit name : PR link
added object detection files : #308
image classification using yolov5 and cnn layers:
#306
added data augmentation techniques :
#304 (edited)
On Mon, 10 Apr 2023 at 18:18, Deepthi ***@***.***>
wrote:
… Following are the changes done as suggested by @param Mirani
<https://mifos.slack.com/team/U04UG3A359N>. Kindly check and do let me
know for further changes and give feedback please.
#308
#306
#304
On Sun, 9 Apr 2023 at 16:02, Deepthi ***@***.***>
wrote:
> Hello Param,
>
> I would do the changes and let you know.
>
> Best regards,
> Deepthi M
>
> On Sun, 9 Apr 2023 at 11:49 AM, Param Mirani ***@***.***>
> wrote:
>
>> Great work!, could you merge your PR’s I see to many PRs and it misses
>> the point of one PR for one task
>> I think you can merge PRs into the following 3
>>
>> 1. Data Augmentation
>> 1. Add in the description of all the changes you are making Eg:
>> Rotation, blur, etc etc
>> 2. Image classification
>> 3. Object detection
>> 1. Using YOLOv5s & CNN
>>
>> This would help in getting the bigger picture of what changes you are
>> making
>>
>> The above is applicable for following PRs
>>
>> #253 <#253>-#301
>> <#301> (~50PRs in total)
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#301 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AS3DRJOZSVRJEQ5GIBMYSYLXAJIGFANCNFSM6AAAAAAWL3MFAI>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298
Changes: Image classification yolov5 model
Screenshots for the change:
Please make sure these boxes are checked before submitting your pull request - thanks!
Run
./gradlew spotlessCheckto ensure the code formatting is maintained.Run the unit tests with
./gradlew checkto make sure you didn't break anything