Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Resource related public APIs #2320

Open
utpilla opened this issue Nov 21, 2024 · 0 comments · May be fixed by #2322
Open

Improve Resource related public APIs #2320

utpilla opened this issue Nov 21, 2024 · 0 comments · May be fixed by #2322
Labels
enhancement New feature or request triage:todo Needs to be traiged.

Comments

@utpilla
Copy link
Contributor

utpilla commented Nov 21, 2024

Resource related public APIs need some improvement:

  1. Remove the timeout parameter from the detect method signature of the trait ResourceDetector. This doesn't seem to add any value. The individual resource detectors implementing this trait can account for timeout in their implementation if required.
  2. Use a builder pattern for creating resource to make it simpler for users to add custom detectors. Currently, this functionality is offered by from_detectors method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage:todo Needs to be traiged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant