You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Resource related public APIs need some improvement:
Remove the timeout parameter from the detect method signature of the trait ResourceDetector. This doesn't seem to add any value. The individual resource detectors implementing this trait can account for timeout in their implementation if required.
Use a builder pattern for creating resource to make it simpler for users to add custom detectors. Currently, this functionality is offered by from_detectors method.
The text was updated successfully, but these errors were encountered:
Resource
related public APIs need some improvement:timeout
parameter from thedetect
method signature of the traitResourceDetector
. This doesn't seem to add any value. The individual resource detectors implementing this trait can account for timeout in their implementation if required.from_detectors
method.The text was updated successfully, but these errors were encountered: