Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs SDK: LoggerProvider is still functional after shutdown #4317

Open
lmolkova opened this issue Nov 23, 2024 · 0 comments
Open

Logs SDK: LoggerProvider is still functional after shutdown #4317

lmolkova opened this issue Nov 23, 2024 · 0 comments
Labels

Comments

@lmolkova
Copy link
Contributor

Spec says

Shutdown SHOULD be called only once for each LogRecordProcessor instance. After the call to Shutdown, subsequent calls to OnEmit are not allowed. SDKs SHOULD ignore these calls gracefully, if possible.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#shutdown-1

LoggerProvider remains fully functional after shutdown and there are tests that validate it

with self.assertLogs(level=logging.WARNING):
logger.warning("Log after shutdown")

While spec language is not strict and the issue is minor, it's nice to fix it to prevent bugs and side-effects in the user code.

Part of open-telemetry/community#1751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants