From ae4acdc687aa3a79ad39447ed3b83a164aaa6782 Mon Sep 17 00:00:00 2001 From: Vadim Korolik Date: Wed, 9 Aug 2023 16:46:27 -0700 Subject: [PATCH 1/2] move @opentelemetry/exporter-jaeger to dev dependencies --- experimental/packages/opentelemetry-sdk-node/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/experimental/packages/opentelemetry-sdk-node/package.json b/experimental/packages/opentelemetry-sdk-node/package.json index 40b3ac0201..70a423c79a 100644 --- a/experimental/packages/opentelemetry-sdk-node/package.json +++ b/experimental/packages/opentelemetry-sdk-node/package.json @@ -66,6 +66,7 @@ "devDependencies": { "@opentelemetry/api": "1.6.0", "@opentelemetry/context-async-hooks": "1.17.0", + "@opentelemetry/exporter-jaeger": "1.17.0", "@types/mocha": "10.0.1", "@types/node": "18.6.5", "@types/semver": "7.5.1", From 4c1dc82bbca3f1fc9047901bb3282483631c4190 Mon Sep 17 00:00:00 2001 From: Vadim Korolik Date: Thu, 10 Aug 2023 18:30:16 -0700 Subject: [PATCH 2/2] fixup! move @opentelemetry/exporter-jaeger to dev dependencies Adds README and CHANGELOG documentation of the change. --- experimental/CHANGELOG.md | 1 + experimental/packages/opentelemetry-sdk-node/README.md | 1 + 2 files changed, 2 insertions(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index aaff8d4389..0c3598e32f 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -48,6 +48,7 @@ All notable changes to experimental packages in this project will be documented ### :bug: (Bug Fix) * fix(exporter-logs-otlp-http): add @opentelemetry/api-logs as dependency +* fix(sdk-node): remove explicit dependency on @opentelemetry/exporter-jaeger. ## 0.41.2 diff --git a/experimental/packages/opentelemetry-sdk-node/README.md b/experimental/packages/opentelemetry-sdk-node/README.md index 2e09308958..b5086b8668 100644 --- a/experimental/packages/opentelemetry-sdk-node/README.md +++ b/experimental/packages/opentelemetry-sdk-node/README.md @@ -36,6 +36,7 @@ Before any other module in your application is loaded, you must initialize the S If you fail to initialize the SDK or initialize it too late, no-op implementations will be provided to any library which acquires a tracer or meter from the API. This example uses Jaeger and Prometheus, but exporters exist for [other tracing backends][other-tracing-backends]. +As shown in the installation instructions, exporters passed to the SDK must be installed alongside `@opentelemetry/sdk-node`. ```javascript const opentelemetry = require("@opentelemetry/sdk-node");