-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow NodeSDK to specify sampler without spanProcessor/exporter #4212
Comments
This means a sampler cannot be configured when using environment variables to set up the export pipeline. |
@dyladan Is this a statement for or against supporting sampler without processor/exporter configuration? |
It's just a statement of the current state sorry. I should have added more context. I think this is something we should fix, but I think it is a feature request and not a bug. |
This actually is a bug the more I think about it. It means the sampler is not being applied correctly. |
I think this is a duplicate of #4004 |
This seems to have been fixed by #4394 - merging the PR did not close this issue. |
What happened?
Steps to Reproduce
Expected Result
The specified sampler is used.
Actual Result
Default sampler is initialized.
Additional Details
This is due to this code: the specified sampler is only accepted when the config also contains a
spanProcessor
or atraceExporter
. However, these concepts are not necessarily require each other. It's should be ok to configure one without the other.OpenTelemetry Setup Code
Relevant log output
No response
The text was updated successfully, but these errors were encountered: