-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to send trace data to collector using 'examples/opentelemetry-web' #4202
Comments
I'm seeing the same issue, and it seems to be related to this change: #4062 The Based on the parser code, serializing the 64bit value to a string (instead of the object with |
@lingyan Is there an older release of this open-telemetry-js that I could run without running into this issue? |
If you can, try downgrading |
The JSON encoding went unnoticed in my PR, where the intermediate types were are serialized directly with |
One thing to consider is whether CI should run some sort of functional test where the output from NodeJS exporters are sent to an OpenTelemetry Collector - and ensure that the data is parsed and collected correctly. Such a test would have failed before the original PR #4062 was merged. |
Thank you for picking this up @seemk
Agreed, we should have something like this. There's #2157 to track this. I added it to the Exporter GA Milestone. |
Adding Wonder if it'd make sense to copy long.js to this codebase instead of copying only the relevant parts. Another option would be to encode I'm for just copying over long.js (as far as I know it can't be added as a dependency due to ESM), but this would cause the package size to go up and I think the JSON exporter is mostly used in browsers 🤔 |
Is using JavaScript's built-int BigInt type an option? |
This was quite the debug session to find the issue. Errors coming from the tools we used weren't helpful. Give this appears to be a broken release (i assume) could a patch be released or retag latest on npm to 0.43.0? Personally it was my first time using OTEL and without a change log or anything to go off this was very hard to pin down. |
+1 for releasing emergency patches in these cases |
This didnt work ... any other alternative fix available? |
Downgrade everything that's 0.44.0 to 0.43.0, this helped me |
Hi all, any traction with this issue? Since it is a major break in functionality, if we believe that having a fix might require more time, I recommend reverting the change that introduced it and re-release asap. |
The fix has been in a PR state for a while: #4220 |
Thanks @seemk |
Looks like all PRs have the same issue currently: https://github.com/open-telemetry/opentelemetry-js/pulls 🤔 |
@pichlermarc seems to be out of office. I wonder who else could approve this and generate a new release. |
Thanks @mateusz-lisik .. didnt work Downgraded these to 0.43.0 @opentelemetry/exporter-trace-otlp-http, @opentelemetry/instrumentation but still facing the same issue |
Any updates on this? It is blocking a project I'm working on. |
Welcome to the club :) |
0.43 does not have this issue but it has another bug (fixed in 0.44) where the library cannot be used from a WebWorker. |
Hello any progress? |
They fixed it. I tested the latest version and it works well. |
What happened?
Steps to Reproduce
Clone this repo and go into
examples/opentelemetry-web
.Run
npm install
andnpm run
.Visit
http://localhost:8090/fetch/
and click on 'Test'.Open up the developer console and under the Network tab, you will see
/traces
responding with 400s.Expected Result
The POST
/traces
requests should succeed.Actual Result
The POST
/traces
requests receives a 400 Bad Request. The response is:The request looks smth as follows:
Additional Details
I suspect this error has something to do with the negative numbers. But, I don't understand enough about the proper behavior of unsigned_long.js.
I am on an ARM Mac and I am not sure if this could be the cause of this issue? I know that my colleague is able to use opentelemetry-js without much problem.
OpenTelemetry Setup Code
package.json
Relevant log output
On the collector side, these are the output:
On the client side:
The text was updated successfully, but these errors were encountered: