Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] update dependency typescript to latest #3955

Closed
pichlermarc opened this issue Jun 29, 2023 · 6 comments
Closed

[all] update dependency typescript to latest #3955

pichlermarc opened this issue Jun 29, 2023 · 6 comments
Assignees
Labels
never-stale triage:accepted This feature has been accepted

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Jun 29, 2023

We should bump typescript to latest in the next major version. As a part of this PR we should document the following:

  • Document policy that typescript versions will be increased with each major SDK version
  • Document the following policy for determining which typescript version to update to: update to the latest version unless a dependency that cannot be updated requires a lower version
@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone Jun 29, 2023
@pichlermarc pichlermarc changed the title chore(deps): update dependency typescript to v5 Update dependency typescript to v5 Jun 29, 2023
@dyladan dyladan added the triage label Sep 27, 2023
@dyladan dyladan added triage:accepted This feature has been accepted and removed triage labels Oct 18, 2023
@dyladan dyladan added the contribfest These small and isolated issues are suitable for Kubecon Contribfest label Nov 8, 2023
@jcarvalho
Copy link

Happy to take this on for KubeCon Contribfest!

@jcarvalho
Copy link

Spoke with @dyladan, and the policy documentation will be added at a later date (still unsure where it will go)

@jcarvalho
Copy link

Looks like there's an overlap between this change and #3952, and there's a catch-22: to upgrade to Typescript 5.2, we need a version of Typedoc that requires Node 16 or higher (guessing that's fine for next, as 16 is no longer a supported LTS version).

Doing some final tweaks to the PR, will open it after I'm back from Kubecon.

jcarvalho added a commit to jcarvalho/opentelemetry-js that referenced this issue Nov 25, 2023
jcarvalho added a commit to jcarvalho/opentelemetry-js that referenced this issue Nov 25, 2023
@dyladan dyladan linked a pull request Dec 1, 2023 that will close this issue
6 tasks
@pichlermarc pichlermarc removed the contribfest These small and isolated issues are suitable for Kubecon Contribfest label Jun 18, 2024
@falsyvalues
Copy link
Contributor

@pichlermarc It might be worth to got straight into TypeScript 5.5 because it contains a lot of improvements (types, speed and workflow).

@pichlermarc pichlermarc changed the title Update dependency typescript to v5 [all] update dependency typescript to latest Jul 1, 2024
@pichlermarc
Copy link
Member Author

@pichlermarc It might be worth to got straight into TypeScript 5.5 because it contains a lot of improvements (types, speed and workflow).

Agree. I changed the title and description to say latest instead. So when we continue work on SDK 2.0 we just bump to whatever is the latest version.

@JamieDanielson JamieDanielson mentioned this issue Aug 7, 2024
12 tasks
@dyladan
Copy link
Member

dyladan commented Aug 7, 2024

Closed in favor of #4870

@dyladan dyladan closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never-stale triage:accepted This feature has been accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants