Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics examplars #2594

Closed
Tracked by #2574
dyladan opened this issue Nov 3, 2021 · 13 comments
Closed
Tracked by #2574

Metrics examplars #2594

dyladan opened this issue Nov 3, 2021 · 13 comments
Labels
feature-request never-stale pkg:sdk-metrics signal:metrics Issues and PRs related to general metrics signal spec-feature This is a request to implement a new feature which is already specified by the OTel specification triage:accepted This feature has been accepted

Comments

@dyladan
Copy link
Member

dyladan commented Nov 3, 2021

Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#exemplar

A metrics exemplar is a trace that is representative of the metrics being collected. The spec requires that exemplars be implemented in a way such that they may be disabled and that if disabled they should have no performance impact (collection should be disabled, not just export). When enabled, the exemplars will come from the currently active context.

Properties:

  • Value

  • Time

  • Attributes

  • Trace ID

  • Span ID

  • ExemplarFilter determines if a meausrement should be sampled

    • value of measurement
    • attributes of measurement
    • context of measurement
    • timestamp
  • ExemplarReservoir provides a method to offer measurements to the reservoir and to collect accumulated exemplars

    • Methods
      • offer
        • value of measurement
        • attributes of measurement
        • context of measurement
        • timestamp
      • collect
        • returns accumulated exemplars

Built-in reservoirs

  • SimpleFixedSizeExemplarReservoir
  • AlignedHistogramBucketExemplarReservoir
@dyladan dyladan added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 3, 2021
@srikanthccv
Copy link
Member

Happy to take this up if no one has already started working on it

@dyladan
Copy link
Member Author

dyladan commented Nov 17, 2021

go ahead. You may want to keep an eye on #2625 since it changes what we have quite a bit

@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 17, 2021
@legendecas
Copy link
Member

@lonewolf3739 a friendly question: are you planning to work on the integration of metric exemplars and the View API?

@srikanthccv
Copy link
Member

@legendecas yes, that's why I didn't use fixes in the PR description that would close this issue. And there is also tiny env related work to do. I will work on the wiring up the stuff as well when other components are ready.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link

github-actions bot commented May 2, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 2, 2022
@legendecas legendecas added the signal:metrics Issues and PRs related to general metrics signal label Sep 1, 2022
@pichlermarc pichlermarc added this to the Metrics After GA milestone Sep 20, 2022
@pichlermarc
Copy link
Member

Hi @srikanthccv 🙂

Friendly question: are you still planning to work on this? 🤔 Otherwise I'll mark this as up-for-grabs in case someone else has some cycles to work on it. 🙂

@srikanthccv
Copy link
Member

srikanthccv commented Sep 20, 2022

@pichlermarc I won't be able to allocate time for this - unassigning myself. Thanks.

@srikanthccv srikanthccv removed their assignment Sep 20, 2022
@pichlermarc pichlermarc added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 20, 2022
@vothanhbinhlt
Copy link

vothanhbinhlt commented Nov 24, 2022

Hello team, any update on this? I am waiting for this feature, I am would like to setup a Nodejs application work with Exemplars, Prometheus and Tempo

@pichlermarc
Copy link
Member

AFAIK no one is currently working on this. Interest in it might pick up once the specification is marked stable.

@antogyn
Copy link

antogyn commented Nov 13, 2024

Hey, is there any way to sponsor this? We'd like to switch to the sdk for metrics but this is a blocker.

@pichlermarc pichlermarc added the spec-feature This is a request to implement a new feature which is already specified by the OTel specification label Nov 13, 2024
@pichlermarc
Copy link
Member

@antogyn this issue is looking for someone to implement it.

It's a feature that's in the OTel spec, so it does not need to go through any special approval process. We will accept code-contributions if someone decides to implement it, unless it's submitted within a feature-freeze period (the first of which is coming up mid December).

@pichlermarc pichlermarc added pkg:sdk-metrics feature-request triage:accepted This feature has been accepted and removed feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 13, 2024
@pichlermarc
Copy link
Member

Hi all, I will close this feature-request as ACCEPTED since the specification is now stable.

This means that it has been refined into a concrete work-item (#5147). Implementation progress will be tracked on #5147 from here on out. I marked it as type:feature rather than feature-reuqest to ensure that it's clear that this is a feature that is accepted and can be worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request never-stale pkg:sdk-metrics signal:metrics Issues and PRs related to general metrics signal spec-feature This is a request to implement a new feature which is already specified by the OTel specification triage:accepted This feature has been accepted
Projects
None yet
Development

No branches or pull requests

6 participants