Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sdk] drop support for Node.js 14.x #2629

Closed
trivikr opened this issue Jan 7, 2025 · 3 comments
Closed

[aws-sdk] drop support for Node.js 14.x #2629

trivikr opened this issue Jan 7, 2025 · 3 comments

Comments

@trivikr
Copy link
Contributor

trivikr commented Jan 7, 2025

Is your feature request related to a problem? Please describe

The AWS SDK for JavaScript v3 announced dropping support of Node.js 14.x in Oct 2023, and dropped it in on May 1, 2024 in aws/aws-sdk-js-v3#6034

The instrumentation still supports Node.js 14.x which has been end-of-life since April 2023.

Describe the solution you'd like to see

End support for Node.js 14.x in instrumentation-aws-sdk

Describe alternatives you've considered

Keep supporting Node.js 14.x in instrumentation-aws-sdk

Additional context

@trivikr
Copy link
Contributor Author

trivikr commented Jan 7, 2025

@open-telemetry/javascript-approvers Can an instrumentation drop support for specific Node.js version in configuration, i.e. engines in package.json, while others keep supporting it?

@pichlermarc
Copy link
Member

pichlermarc commented Jan 8, 2025

Can an instrumentation drop support for specific Node.js version in configuration, i.e. engines in package.json, while others keep supporting it?

@trivikr unfortunately no (for now) since it is included in the @opentelemetry/auto-instrumentations-node metapackage - when dropping support for an included instrumentation we'd also have to drop support for Node.js 14 for the metapackage.

However, we're planning to release 2.x of the core repo in February open-telemetry/opentelemetry-js#5148.
Once the we publish 2.0 in core, then we can also drop support Node.js 14 in the metapackage and the AWS SDK instrumentation (we have to drop support, actually). 🙂

@pichlermarc
Copy link
Member

SDK 2.0 will also drop support for Node.js 16 so that will also be dropped here.

@trivikr trivikr closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants