Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #375

Open
baentsch opened this issue Mar 19, 2024 · 2 comments
Open

Refactor code #375

baentsch opened this issue Mar 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@baentsch
Copy link
Member

While reviewing #317 various instances of not really well encapsulated code have been found not only concerned with CompositeSigs, e.g., https://github.com/open-quantum-safe/oqs-provider/pull/317/files#r1516527180. This issue is to suggest and track a refactoring of this code.

At the same time, it would be prudent to review code during such refactoring for memory leakage even though it doesn't seem to be discovered by asan, e.g., #317 (comment)

@baentsch
Copy link
Member Author

Also see thoughts in #526 in this regard (code complexity improvements)

@baentsch
Copy link
Member Author

Composite code added in #317 and #549 warrants a particular review as the exact rationale and design isn't immediately visible from the code (at least for me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant