Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raunak/channel close #69

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Raunak/channel close #69

merged 7 commits into from
Mar 29, 2024

Conversation

RnkSngh
Copy link
Collaborator

@RnkSngh RnkSngh commented Mar 21, 2024

PR to add channel close methods + handlers; mainly equivalent to @nicopernas 's channel close branch, but with some additional unit tests on the contract level to verify state

Copy link

coderabbitai bot commented Mar 21, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@RnkSngh RnkSngh changed the base branch from v2 to raunak/upgradeable-dispatcher March 21, 2024 05:15
@RnkSngh RnkSngh changed the base branch from raunak/upgradeable-dispatcher to v2 March 21, 2024 05:17
@RnkSngh RnkSngh linked an issue Mar 21, 2024 that may be closed by this pull request
@nicopernas nicopernas force-pushed the raunak/channel-close branch from fffa2e4 to cbee4eb Compare March 21, 2024 19:47
contracts/core/Dispatcher.sol Outdated Show resolved Hide resolved
test/Dispatcher.closeChannel.t.sol Show resolved Hide resolved
contracts/core/Dispatcher.sol Show resolved Hide resolved
test/Dispatcher.closeChannel.t.sol Outdated Show resolved Hide resolved
contracts/core/Dispatcher.sol Outdated Show resolved Hide resolved
@RnkSngh RnkSngh merged commit 7cb9c0f into v2 Mar 29, 2024
@RnkSngh RnkSngh deleted the raunak/channel-close branch March 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vibc-core-smart-contracts: Add channel-close support
3 participants