-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jak2] Fix bug where spinning into grind doesnt break clasps in dig1 #3740
Conversation
Yes |
However, I'm not sure we should be pushing this. I don't know if this is unintended behavior or not and it's not really the cause of the clasps not breaking even when you grind the rail next to them. |
I hear the point about not changing intended vanilla behavior of course, though I'm not sure what you mean about this not being the cause, maybe we are talking about different things? If you grind across the rails the clasps break as intended, but if you spin straight into the same exact grind, they don't break. I can't imagine why that would be intentional |
Yeah, but you do grind into them, the game just incorrectly counts it as a board-spin if you spin into the grind no? |
When you do a trick right before starting to grind on the rail, the cables don't break is what Barg was getting at. |
Yeah to clarify it a different way, when you do a 360 spin and grind your boost gets "stored" (you can also do this by just jumping quickly when landing) and if you are in this state, the cables don't break. |
@ManDude I added a |
if you sideflip into grind in the digsite mission, the clasps wont break because it is considered a
board-spin
attack instead ofboard
. This extends the condition to allow forboard-spin
as well.Should I wrap this in andone#if PC_PORT
?