Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jak2] Fix bug where spinning into grind doesnt break clasps in dig1 #3740

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

dallmeyer
Copy link
Contributor

@dallmeyer dallmeyer commented Nov 2, 2024

if you sideflip into grind in the digsite mission, the clasps wont break because it is considered a board-spin attack instead of board. This extends the condition to allow for board-spin as well.

Should I wrap this in an #if PC_PORT? done

@ManDude
Copy link
Member

ManDude commented Nov 2, 2024

Yes

@ManDude
Copy link
Member

ManDude commented Nov 2, 2024

However, I'm not sure we should be pushing this. I don't know if this is unintended behavior or not and it's not really the cause of the clasps not breaking even when you grind the rail next to them.

@dallmeyer
Copy link
Contributor Author

I hear the point about not changing intended vanilla behavior of course, though I'm not sure what you mean about this not being the cause, maybe we are talking about different things?

If you grind across the rails the clasps break as intended, but if you spin straight into the same exact grind, they don't break. I can't imagine why that would be intentional

@ManDude
Copy link
Member

ManDude commented Nov 2, 2024

"I can't imagine why that would be intentional"

The game specifically asks you to grind on them:
image

"Daxter: Grind on the support bases to break the cables."

@Zedb0T
Copy link
Contributor

Zedb0T commented Nov 2, 2024

Yeah, but you do grind into them, the game just incorrectly counts it as a board-spin if you spin into the grind no?

@Hat-Kid
Copy link
Member

Hat-Kid commented Nov 2, 2024

When you do a trick right before starting to grind on the rail, the cables don't break is what Barg was getting at.

@xTVaser
Copy link
Member

xTVaser commented Nov 2, 2024

Yeah to clarify it a different way, when you do a 360 spin and grind your boost gets "stored" (you can also do this by just jumping quickly when landing) and if you are in this state, the cables don't break.

@dallmeyer
Copy link
Contributor Author

@ManDude I added a (focus-test? *target* rail) condition for board-spin so it should only change the behavior if you're actually grinding the rail 👍

@Hat-Kid Hat-Kid merged commit 2a41bc6 into open-goal:master Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants