Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that responses should be smooth and well-sampled #68

Open
cdeil opened this issue Oct 4, 2016 · 2 comments
Open

Add note that responses should be smooth and well-sampled #68

cdeil opened this issue Oct 4, 2016 · 2 comments

Comments

@cdeil
Copy link
Member

cdeil commented Oct 4, 2016

We should add a note to the current IACT DL3 specs that responses are expected to be smooth and well-sampled, i.e. the burden of e.g. smoothing responses and choosing response sampling is on the DL3 data producer, not the science tools consuming the files.

This has been discussed in detail the the April f2f meeting and I think isn't controversial, so "just" needs someone to make this clear in the current spec. But the question came up in another issue (see #67 (comment)) in a discussion with @kosack , so I'm splitting it out into this separate reminder issue.

General schemes to handle parameter ranges where the responses are bad (like mask or weight arrays) haven't been investigated, but might ultimately be needed. If you'd like to discuss this, I'd suggest to split it out yet again into a separate (very long-term, large effort) separate issue.

@jknodlseder
Copy link
Collaborator

jknodlseder commented Jan 13, 2017 via email

@cdeil cdeil modified the milestones: 0.2, 0.3 Jun 20, 2018
@cdeil
Copy link
Member Author

cdeil commented Jun 20, 2018

I'm about to release v0.2, so moving this issue to v0.3 milestone.

I still think a statement on this point in the DL3 spec would be very important. Especially in CTA there was a misunderstanding in the past year, where the DL3 IRF producers gave histograms with some noise and the DL3 consumers (Gammapy and ctools) had some problems because they do simple linear interpolation / integration on the IRFs to compute reduced responses, that assume that the IRFs are smooth and well sampled.

cc @genotmaier @kosack

@cdeil cdeil mentioned this issue Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants