feat: remove sync server (#114) #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync server is deprecated as it is part of flagd. Hence that we can remove all of the custom logic. closes: #114 Signed-off-by: Simon Schrottner <[email protected]>
2 tasks
aepfli
requested review from
toddbaert,
beeme1mr,
warber,
alexandraoberaigner and
guidobrei
toddbaert
approved these changes
Nov 26, 2024
toddbaert
reviewed
Nov 26, 2024
| @@ -61,6 +61,9 @@ jobs: | |||
| tags: | | |||
| ${{ env.REGISTRY }}/open-feature/${{ env.FLAGD_IMAGE_NAME }}:${{ needs.release-please.outputs.release_tag_name }} | |||
| ${{ env.REGISTRY }}/open-feature/${{ env.FLAGD_IMAGE_NAME }}:latest | |||
| # For backwards compatibility remove as soon as nobody is using sync server anymore | |||
toddbaert
deleted the
114-testing-remove-testbed-sync-server-in-favor-of-flagd-v091
branch
|
-2000 lines YEEEES! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync server is deprecated as it is part of flagd. Hence we can remove all of the custom logic.
closes: #114