Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference.md: add contracting and processing definitions #1716

Open
wants to merge 4 commits into
base: 1.2-dev
Choose a base branch
from
Open

reference.md: add contracting and processing definitions #1716

wants to merge 4 commits into from

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Nov 12, 2024 •
edited
Loading

closes #1714

I deliberately included the definitions and nothing else other than an introductory sentence as otherwise it would essentially just be a copy of https://standard.open-contracting.org/staging/1.2-dev/en/guidance/map/contracting_planning_processes/

duncandewhurst
duncandewhurst reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few more suggestions in #1714 (comment). Let's hold fire on the PR until we've decided what to do.

docs/schema/reference.md Show resolved Hide resolved
@odscjen
Copy link
Contributor Author

odscjen commented Nov 18, 2024 •
edited
Loading

suggestions in #1714 now applied. Haven't updated the releaseProcess reference section as I think that requires it's own PR (see #1713)

duncandewhurst
duncandewhurst requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@duncandewhurst duncandewhurst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the worked example.

docs/schema/reference.md Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
@odscjen
Copy link
Contributor Author

odscjen commented Nov 19, 2024

worked example now removed, I'd just been waiting on confirmation in the issue that that was what was agreed upon

duncandewhurst
duncandewhurst approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@duncandewhurst duncandewhurst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Haven't updated the releaseProcess reference section as I think that requires it's own PR (see #1713)

I've added a reminder to #1713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncandewhurst duncandewhurst duncandewhurst approved these changes

@jpmckinney jpmckinney Awaiting requested review from jpmckinney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature contracing process and planning process definitions in the reference documentation
2 participants
@odscjen @duncandewhurst