Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional check: Releases with same date for given ocid #90

Open
ColinMaudry opened this issue Apr 19, 2021 · 3 comments
Open

Additional check: Releases with same date for given ocid #90

ColinMaudry opened this issue Apr 19, 2021 · 3 comments

Comments

@ColinMaudry
Copy link
Member

If two releases or more with the same ocid and date, should the tool return a warning?

Follow up of open-contracting/standard#848

cc @duncandewhurst @jpmckinney

@jpmckinney
Copy link
Member

We could do this check here. We have similar uniqueness checks, so it should not be difficult to add. However, implementers only upload one package at a time, and this issue is maybe more likely to occur within a full dataset, rather than in a sample.

@duncandewhurst
Copy link

Publishers sometimes mistakenly set date in each release to the date the whole package was generated, so it would be useful to include this check, even at the package level.

@jpmckinney
Copy link
Member

Makes sense!

@jpmckinney jpmckinney changed the title Add an additionnal check to catch the releases with same ocid and same date Add an additional check to catch the releases with same ocid and same date Aug 18, 2021
@jpmckinney jpmckinney changed the title Add an additional check to catch the releases with same ocid and same date Additional check: Releases with same date for given ocid Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants