Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for duplicate milestone IDs #63

Open
duncandewhurst opened this issue Feb 13, 2019 · 3 comments
Open

Check for duplicate milestone IDs #63

duncandewhurst opened this issue Feb 13, 2019 · 3 comments

Comments

@duncandewhurst
Copy link

The OCDS schema currently permits duplicate milestones in the planning, tender and contract sections when it shouldn't. See open-contracting/standard#814

Updating the schema would be a backward incompatible change, so until we can do that we should add an additional check for duplicate milestones (and milestone ids) to CoVE, to help publishers prepare for the change.

cc @pindec

@jpmckinney
Copy link
Member

jpmckinney commented Mar 19, 2019

Note: The lack of uniqueItems means there can be duplicate milestone objects.

The other check, about duplicate id values, also applies to any other object in an array that is not wholeListMerge – so we might want a separate issue for that one.

@jpmckinney
Copy link
Member

On today's call, this was mentioned as a candidate for the Apr-May 2019 sprint.

@duncandewhurst
Copy link
Author

Just to flag that I came across this issue again today when checking data for Afghanistan.

@robredpath robredpath transferred this issue from OpenDataServices/cove Oct 14, 2020
@robredpath robredpath transferred this issue from another repository Oct 14, 2020
@jpmckinney jpmckinney transferred this issue from open-contracting/cove-ocds Oct 14, 2020
@jpmckinney jpmckinney changed the title OCDS: Additional check for duplicate milestone ids Check for duplicate milestone ids Oct 15, 2020
@jpmckinney jpmckinney changed the title Check for duplicate milestone ids Check for duplicate milestone IDs Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants