Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host search.js file in this repository #229

Open
jpmckinney opened this issue Nov 24, 2020 · 3 comments
Open

Host search.js file in this repository #229

jpmckinney opened this issue Nov 24, 2020 · 3 comments
Labels
S: docs Relating to the OCDS documentation server

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Nov 24, 2020

Can also document what needs to be updated if indexing approach or search endpoint change:

Search endpoint:

  • Update standard_theme
  • Re-deploy all docs that use the search endpoint

Indexing:

  • Update deploy-docs.sh in deploy repo
  • Update documentation in deploy repo (also need to update link to search.js in docs.rst)
@jpmckinney jpmckinney transferred this issue from open-contracting-archive/standard-search Nov 27, 2020
@jpmckinney
Copy link
Member Author

jpmckinney commented Nov 28, 2020

It might be best if the search JS is retrieved from a central location, so that it can easily be rolled out to all sites, rather than having to rebuild each site. The JS file can be hosted by the deploy repo, since it is coupled to the Elasticsearch configuration.

@jpmckinney jpmckinney transferred this issue from open-contracting/ocds-index Dec 24, 2020
@jpmckinney jpmckinney changed the title Document what needs to be updated if indexing approach or search endpoint change Host search.js file Dec 24, 2020
@jpmckinney jpmckinney changed the title Host search.js file Host search.js file in this repository Dec 24, 2020
@jpmckinney jpmckinney added the S: docs Relating to the OCDS documentation server label Dec 24, 2020
@jpmckinney
Copy link
Member Author

jpmckinney commented Jan 5, 2021

As part of this, can update to follow the style guide (notably, removing jQuery): https://ocp-software-handbook.readthedocs.io/en/latest/javascript/index.html

@jpmckinney
Copy link
Member Author

Can use https://www.jsdelivr.com/ instead of raw.githubusercontent.com

@jpmckinney jpmckinney assigned jpmckinney and unassigned jpmckinney Jun 8, 2021
@jpmckinney jpmckinney mentioned this issue Mar 10, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: docs Relating to the OCDS documentation server
Projects
None yet
Development

No branches or pull requests

1 participant