Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add region to collection #312

Merged
merged 5 commits into from
Nov 2, 2023
Merged

feat: add region to collection #312

merged 5 commits into from
Nov 2, 2023

Conversation

yolile
Copy link
Member

@yolile yolile commented Nov 2, 2023

Closes #263

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two changes then good to merge.

data_registry/models.py Show resolved Hide resolved
data_registry/models.py Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

jpmckinney commented Nov 2, 2023

Thinking more: Georgia is geographically both Europe and Asia. Geopolitically, we typically group Georgia into Eastern Europe and Central Asia. Kyrgyzstan is geographically Asia, but we typically put it in the same region as Georgia.

So maybe add Eastern Europe & Central Asia EECA.


Cyprus is geographically Asia, but is culturally/geopolitically Europe (so we can put it as Europe).


Also a bit weird that North America means US & Canada, but I don't think "Anglo America" is common usage. (Also, this still includes Caribbean countries like Jamaica.)


Latam should probably be Latin America & Caribbean LAC.


Sidenote: The UN just gives up and has a "Western Europe and Others" group that includes, Canada, US, Australia: https://en.wikipedia.org/wiki/United_Nations_Regional_Groups#Western_European_and_Others_Group_(WEOG)

@yolile yolile merged commit ac078c6 into main Nov 2, 2023
10 checks passed
@yolile yolile deleted the 263-regions branch November 2, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add region filter to Registry
2 participants