Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion errors: 'you may have a duplicate identifier' only specifies one of the sheets the duplicate appears in #129

Open
duncandewhurst opened this issue Jun 22, 2020 · 8 comments
Labels
spreadsheet input Relating to when a spreadsheet is provided as input

Comments

@duncandewhurst
Copy link
Contributor

duncandewhurst commented Jun 22, 2020

The 'duplicate heading' error message doesn't specify which sheets the duplicate headings are in.

The 'you may have a duplicate identifier' error message only specifies one of the sheets the duplicate appears in.

image

Including all of the sheet names in the warning would make it easier to troubleshoot errors.

@robredpath
Copy link
Contributor

robredpath commented Aug 20, 2020

Reviewed 2020-08-20:

We think that the "duplicate heading" error might be easier to fix, whereas the second one will be quite a lot harder.

@rhiaro
Copy link
Contributor

rhiaro commented Sep 3, 2020

@duncandewhurst do you have a sample of the data that caused this error to hand?

@duncandewhurst
Copy link
Contributor Author

Here you go. In this example, the other sheet which should appear in the error is 'Input: Contracting processes'

@Bjwebb
Copy link
Contributor

Bjwebb commented Sep 29, 2020

We split this into 2 trello cards, 1 for the duplicate header warnings, and 1 for the merge failure.

The first of these has been fixed, and is now deployed to the cove dev site http://cove.dev1.cove.opencontracting.uk0.bigv.io/review/. @duncandewhurst if you get chance, it would be great to know if this works as expected. This should go live over the next couple of days.

The second is still sat on the backlog.

@duncandewhurst
Copy link
Contributor Author

@duncandewhurst if you get chance, it would be great to know if this works as expected

Looks good!

@Bjwebb
Copy link
Contributor

Bjwebb commented Sep 30, 2020

That fix is live now.

@robredpath robredpath transferred this issue from OpenDataServices/cove Oct 14, 2020
@robredpath robredpath transferred this issue from another repository Oct 14, 2020
@jpmckinney
Copy link
Member

@duncandewhurst Can you update the issue title and description to reflect the remaining (second) issue?

@jpmckinney jpmckinney added check results Relating to how specific checks are reported spreadsheet input Relating to when a spreadsheet is provided as input and removed check results Relating to how specific checks are reported labels Oct 14, 2020
@duncandewhurst duncandewhurst changed the title Include sheet names in conversion warnings Conversion errors: 'you may have a duplicate identifier' only specifies one of the sheets the duplicate appears in. Aug 25, 2021
@duncandewhurst duncandewhurst changed the title Conversion errors: 'you may have a duplicate identifier' only specifies one of the sheets the duplicate appears in. Conversion errors: 'you may have a duplicate identifier' only specifies one of the sheets the duplicate appears in Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spreadsheet input Relating to when a spreadsheet is provided as input
Projects
None yet
Development

No branches or pull requests

5 participants