Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional system_info #246

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Added additional system_info #246

wants to merge 9 commits into from

Conversation

amd-pworfolk
Copy link
Contributor

Added collection of additional data for system_info, and updated method to collect Python package versions.

Closes #245

ramkrishna2910
ramkrishna2910 requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@ramkrishna2910 ramkrishna2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

src/turnkeyml/common/build.py Outdated Show resolved Hide resolved
src/turnkeyml/common/build.py Outdated Show resolved Hide resolved
amd-pworfolk
amd-pworfolk commented Dec 6, 2024
View reviewed changes
Copy link
Contributor Author

@amd-pworfolk amd-pworfolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by migrating from wmic to wmi package.

@amd-pworfolk
Copy link
Contributor Author

The new system_info code is now passing all the tests, including linux. If you have access to a linux box or WSL, would you please run the new file I created, src/turnkeyml/common/system_info.py, as a script and check that the output looks good on those platforms. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramkrishna2910 ramkrishna2910 ramkrishna2910 requested changes

@danielholanda danielholanda danielholanda left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture additional system info
3 participants
@amd-pworfolk @danielholanda @ramkrishna2910