Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused argument: custom_parsers #1119

Open
Fred51 opened this issue Jul 17, 2024 · 1 comment
Open

Unused argument: custom_parsers #1119

Fred51 opened this issue Jul 17, 2024 · 1 comment

Comments

@Fred51
Copy link

Fred51 commented Jul 17, 2024

Hello there,

I was trying to see how I would write a custom parser to make it so that a model converted from xgboost classifier could only return probabilities, not the standard label and dictionary of probabilities. I eventually realized it didn't matter what I passed to custom_parsers in convert_sklearn, it returned the same output.

Diving into the code I noticed that, unless I'm missing something, this custom_parsers argument is unused in the parse_sklearn_simple_function.

Is there intention to make use of this parameter? Should it be removed or perhaps an error thrown that custom parsers are currently unsupported?

def _parse_sklearn_simple_model(scope, model, inputs, custom_parsers=None, alias=None):

@xadupre
Copy link
Collaborator

xadupre commented Aug 1, 2024

You can read this example to see how to define your own parser: https://onnx.ai/sklearn-onnx/auto_tutorial/plot_mcustom_parser.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants