Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning fails on accented filenames #5

Open
SergioMendolia opened this issue Mar 11, 2020 · 2 comments
Open

Scanning fails on accented filenames #5

SergioMendolia opened this issue Mar 11, 2020 · 2 comments

Comments

@SergioMendolia
Copy link
Contributor

Failed item in queue Error: Command failed with exit code 128: git blame --incremental 
fatal: pas de chemin "content/articles/vernissage-des-\303\251ditions-alphil.json" dans master
    at makeError (/usr/local/lib/node_modules/absorption/node_modules/execa/lib/error.js:58:11)
    at handlePromise (/usr/local/lib/node_modules/absorption/node_modules/execa/index.js:114:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async getBlame (/usr/local/lib/node_modules/absorption/src/git.js:66:3) {
  shortMessage: 'Command failed with exit code 128: git blame --incremental "content/articles/vernissage-des-\\303\\251ditions-alphil.json" master',
  command: 'git blame --incremental "content/articles/vernissage-des-\\303\\251ditions-alphil.json" master',
  exitCode: 128,
  signal: undefined,
  signalDescription: undefined,
  stdout: '',
  stderr: 'fatal: pas de chemin "content/articles/vernissage-des-\\303\\251ditions-alphil.json" dans master',
  failed: true,
  timedOut: false,
  isCanceled: false,
  killed: false
}

I know... nobody ever uses accents on filenames, but on static websites with user-generated content, this happens.

@onigoetz
Copy link
Owner

Hmm indeed, I’ll look into this as well.
In the meantime you can set the accented file to have a weight of zero to ignore it and continue

@onigoetz
Copy link
Owner

Sorry it's been a long time, I'm trying to investigate this. Did the following

❯ mkdir accent_test
❯ cd accent_test
❯ git init
Initialized empty Git repository in /Users/onigoetz/Sites/Libs/accent_test/.git/
❯ echo "My GitHub Page" > accentué.txt
❯ git add *
❯ git commit -m "first commit"
[master (root-commit) 458db71] first commit
 1 file changed, 1 insertion(+)
 create mode 100644 accentué.txt

And was able to run absorption on it as expected.

Can you please try with version 0.6.0 if you still have the same issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants