Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement version recognition in Accept header #95

Open
saimaz opened this issue Dec 15, 2015 · 3 comments
Open

Implement version recognition in Accept header #95

saimaz opened this issue Dec 15, 2015 · 3 comments
Milestone

Comments

@saimaz
Copy link
Member

saimaz commented Dec 15, 2015

We should require format: application/vnd.ongr.v3+json

@saimaz saimaz added this to the v1.0.0 milestone Dec 15, 2015
@trandangtri
Copy link
Contributor

@saimaz, in case this format is required, so how do you think about the configuration:

ongr_api:
   version_in_url: true

IMO, it's useless and we could remove it

@saimaz
Copy link
Member Author

saimaz commented Dec 31, 2015

This config was left for legacy support if user can't handle versions via headers and leave them in URL. IMO would be nice to support both ways in URL and in Header.

@saimaz saimaz modified the milestones: v1.1.0, v1.0.0 Jan 4, 2016
@saimaz
Copy link
Member Author

saimaz commented Jan 4, 2016

For 1.0.0 lets keep version in the header. Later we will figure out how to implement it in both ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants