Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"with git" proposal: recommend degit over clone, and add init steps to Makefile #46

Open
olets opened this issue Jul 16, 2022 · 2 comments

Comments

@olets
Copy link

olets commented Jul 16, 2022

Great to see someone's ddev Craft CMS setup!

I tried it out, installing via Composer, and immediately hit #38. Saw the fix was merged, so tried again following your instructions for installing with Git.
My impression: two changes would make it even easier for people to start from the unreleased bleeding edge

  • using degit instead of git-clone would obviate the need to manually remove the .git directory
  • moving the "clean up and set" commands into the Makefile (not sure what name would be best. make init?) would reduce 4 steps to 1

I can make a pull request if you like the idea.

@johndwells
Copy link
Contributor

Thanks @olets for your suggestion. I'm not familiar with degit, so I'll have to take a closer look. I'm interested in the least amount of dependencies, but I might reference degit as a suggested alternative / helper tool.

Re: Makefile, I think there are a number of improvements that could be made to the various recipes, so I'll think about your suggestion for sure.

@olets
Copy link
Author

olets commented Jul 18, 2022

Here's the change in my fork for comparison olets#1

My make change is pretty naive, there's probably a name that more clearly says "if you're using the upstream repo as a starting point"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants