Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git-lfs for remote locking of ensembles during deploy. #94

Closed
aszs opened this issue Dec 2, 2021 · 0 comments
Closed

Use git-lfs for remote locking of ensembles during deploy. #94

aszs opened this issue Dec 2, 2021 · 0 comments

Comments

@aszs
Copy link
Member

aszs commented Dec 2, 2021

Currently when you deploy, a lock is held on the ensemble being deployed but it is only local to the machine that is running unfurl (YamlManifest.lock()). To prevent deploy job from running on another machine at the same time we can use git-lfs to provide remote locking. We just need to call git lfs lock <ensemble>.remotelock and later git lfs unlock <ensemble>.remotelock (I've already added .remotelock lockable to the .gitattributes file we create) -- see https://github.com/git-lfs/git-lfs/wiki/File-Locking for more info. This functionality should be implemented in repo.py

Ideally the .unfurl-home ensemble template would include a package artifact (depends on #93) that installs git-lfs to make sure the git-lfs extension is installed locally -- it seems that all the major distributions, include brew, include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant