[KT] Rename out-of-place esimd radix_sort as radix_sort_copy #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
akukanov
reviewed
Jun 24, 2024
documentation/library_guide/kernel_templates/esimd/radix_sort_by_key.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Hoeflinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the convention of the standard library when both an in-place and out-of-place algorithm are provided to to label out-of-place versions of APIs as
*_copy. Seepartial_sort[_copy],remove[_copy],partition[_copy], etc..This PR deprecates the existing out-of-place overloads for
radix_sortandradix_sort_by_keyin favor ofradix_sort_copyandradix_sort_copy_by_key. We originally avoided this to limit the line length with the large KT namespace, but the convention is strong and consistent enough to warrant this change.This updates the code, the testing, and the documentation.
This PR is based on #1586 to avoid merge conflicts, and should be merged into main after that PR is merged. For now I will point it at that PR and keep it as "draft", to properly show the diff.