From 150090b0c1ea8790158b745e411dac7b251e45d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=BCseyin=20Tekinaslan?= Date: Sat, 22 Sep 2018 03:10:32 +0300 Subject: [PATCH 1/3] Update rollbar configuration --- config/initializers/rollbar.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config/initializers/rollbar.rb b/config/initializers/rollbar.rb index 8de1e107..21afac22 100644 --- a/config/initializers/rollbar.rb +++ b/config/initializers/rollbar.rb @@ -12,6 +12,8 @@ # config.person_method = "my_current_user" # config.person_id_method = "my_id" + config.enabled = false unless Rails.env.production? || Rails.env.beta? + # Additionally, you may specify the following: config.person_username_method = 'id_number' config.person_email_method = 'email' From b20107511669ea5e5e50455924e31fcf494c286a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=BCseyin=20Tekinaslan?= Date: Sat, 22 Sep 2018 03:13:10 +0300 Subject: [PATCH 2/3] Fix error params and condition for addresses action --- app/serializers/kps/queries/addresses_serializer.rb | 1 - app/services/lib/services/kps/constants.rb | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/serializers/kps/queries/addresses_serializer.rb b/app/serializers/kps/queries/addresses_serializer.rb index 264541f1..1b1e1601 100644 --- a/app/serializers/kps/queries/addresses_serializer.rb +++ b/app/serializers/kps/queries/addresses_serializer.rb @@ -7,7 +7,6 @@ class AddressesSerializer < Serializer attribute :current_address do address = object[:yerlesim_yeri_adresi] - next if address[:hata_bilgisi] { full_address: address[:acik_adres], diff --git a/app/services/lib/services/kps/constants.rb b/app/services/lib/services/kps/constants.rb index 6ba310f9..520bf949 100644 --- a/app/services/lib/services/kps/constants.rb +++ b/app/services/lib/services/kps/constants.rb @@ -8,7 +8,8 @@ class Queries < Base operation: :adres_sorgula, result: %i[adres_sorgula_response return sorgula_result sorgu_sonucu kimlik_noile_kisi_adres_bilgileri], - status: %i[adres_sorgula_response return sorgula_result sorgu_sonucu hata_bilgisi] + status: %i[adres_sorgula_response return sorgula_result sorgu_sonucu + kimlik_noile_kisi_adres_bilgileri hata_bilgisi] }, identities: { operation: :sorgula, From 9f3ec7ed0ddf1f8fdd6e5d4fefaca5936b18754b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=BCseyin=20Tekinaslan?= Date: Sat, 22 Sep 2018 03:24:32 +0300 Subject: [PATCH 3/3] Update .rubocop.yml --- .rubocop.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 2dda18a2..a4ba0ea1 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -14,5 +14,11 @@ AllCops: - Vagrantfile Documentation: Enabled: false +Rails/UnknownEnv: + Environments: + - production + - development + - test + - beta Metrics/LineLength: Max: 120 \ No newline at end of file