Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the message length from the bridge contract #81

Open
akolotov opened this issue May 17, 2018 · 0 comments
Open

Get the message length from the bridge contract #81

akolotov opened this issue May 17, 2018 · 0 comments

Comments

@akolotov
Copy link
Contributor

akolotov commented May 17, 2018

Currently the length of message to withdrawal is hard coded:

https://github.com/poanetwork/poa-bridge-contracts/blob/93969cd934190649d42691f054676d0d16a9777e/contracts/libraries/Message.sol#L65

and it is also hard coded in the bridge code:

https://github.com/poanetwork/poa-bridge/blob/cdb79b9ba72bc7094ab7e03b133d4e03a1b5d48a/bridge/src/message_to_mainnet.rs#L19

So, it is necessary to change the length in both places if format of the message is being changed.

As soon as the issue omni/tokenbridge-contracts#39 is addressed in the bridge contract, it is necessary to change the bridge code as so the bridge calls the new method during startup sequence and gets actual value for the message. It will reduce amount of work when new bridge contracts are being introduced.

noot pushed a commit to noot/poa-bridge that referenced this issue Jul 18, 2018
issue 55 - split ForeignBridge.transfer into two functions and increase branch coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant